search

Yalir / sfeMovie

sfeMovie is a simple C++ library that lets you play movies in SFML based applications. It relies on FFmpeg to read medias and remains consistent with SFML's naming conventions.
http://sfemovie.yalir.org/
GNU Lesser General Public License v2.1
114 stars 37 forks source link

Install sfeMovie sample application via CMake #50

Open firefly2442 opened 10 years ago

firefly2442 commented 10 years ago

If BUILD_SFEMOVIE_SAMPLE is checked in CMake, this will build the sample application. This can be run from the build directory. However, it does not get installed to the CMAKE_INSTALL_PREFIX location.

What do you think about making it install it there?

Ceylo commented 10 years ago

The main question here is: is it worth it?

I agree selecting BUILD_SFEMOVIE_SAMPLE means the user wants that demo program. At least he wants to execute it, but does he want to have it installed for easier use?

firefly2442 commented 10 years ago

Yep. Just something to consider I guess. Up to you. :)

Ceylo commented 10 years ago

That'll depend on how many users want this feature :)

So to anyone interested outta here, come on and vote!

bluekirby0 commented 10 years ago

Unless you plan to add features to the sample program itself that can rival VLC or ffplay I would say leave the sample program where it can be tested easily with a new build and leave it at that.

Samples are generally made to showcase what a library can do without stupendously cluttering up the code with superfluous "added value" features, though, so I'd just leave it like it is and add features to it only when said features are provided by sfeMovie itself.

Ceylo commented 10 years ago

Thanks for you feedback :) , this is also my opinion so for now it'll probably stay as it is.

feliwir commented 10 years ago

it would be awesome if you'd add the streamselection/seeking once you have it done, so they can see how it works (which is the purpose of a sample i guess)

Ceylo commented 10 years ago

Yep this will most probably be done :)