Closed firefly2442 closed 8 years ago
Thanks for pointing out and the for the fix :) Just checked and it looks all good to me
In Stream.cpp line 201, the check you removed should have been kept: requestMoreData() updates the packet list. Hopefully it had visible consequences (big lag in video when seeking) so it could be fixed :)
Ahh darn, sorry about that. It was the same conditional check so I was unsure why they were split like that.
Don't worry, I think the code is badly designed at the moment because it relies on "side effect", so easy to get fooled.
cppcheck found these. Basically, .empty() is a constant access speed whereas .size() is linear. Probably not a huge deal but I think it's also easier to read. As always, please double check this doesn't break anything. :)