Yamahari / ILikeWood

This mod adds wood variants for blocks that should have one but don't.
https://www.curseforge.com/minecraft/mc-mods/i-like-wood
MIT License
8 stars 16 forks source link

[Enhancement] Rotate the top/bottom UVs for panel stairs to match panel blocks & slabs #49

Open triggerhurt opened 2 years ago

triggerhurt commented 2 years ago

The current panel stair model creates a minor inconsistency in how stairs, slabs, and planks interact when used in combination, which causes them to stand out a bit: image

An example of how it looks in vanilla: image

triggerhurt commented 2 years ago

Ah. I've just realized that an issue exists for this already (issue #8). My apologies.

Yamahari commented 2 years ago

Yup This has been there since the beginning, might need to change the way panels look to fix it properly Probably needs to be a horizontally rotatable planks block turned on it's side x)

triggerhurt commented 2 years ago

Here, I fixed it image image image

This is a resourcepack that edits the three template files for the stair blockmodels; I don't know how pull requests work or if I can even create one, but feel free to use it in the mod, if possible. ilikewood-stairfix.zip

Yamahari commented 2 years ago

Does it work if you turn the stairs upside down though

triggerhurt commented 2 years ago

Yep. The first screenshot demonstrates all stair variants in action Edit to add a screenshot showing the upside-down stairs working image

Yamahari commented 2 years ago

2022-02-17_09 58 34 2022-02-17_09 59 23 2022-02-17_09 57 12 2022-02-17_09 57 39 2022-02-17_09 58 03

still doesnt line up on some rotations properly x) I will have a look at it when I am doing with what I am working on atm

triggerhurt commented 2 years ago

Seems I didn't realize the scope of the problem: Apparently it's an issue with Minecraft's stair block implementation (or possibly general rotations...); evidently it doesn't really like rotated UVs. I wish you the best of luck on coming up with a good solution. It's kinda weird that it doesn't have a problem with upside-down stairs, it just specifically breaks the uv orientation for regular stairs, despite using the exact same blockmodel...