Closed YamatoSecurity closed 11 months ago
@YamatoSecurity Thanks for your issue. I have two ideas.
I think better 2 than 1. What do you think?
@hitenkoku Thanks for the question! Yes, I think we should prioritize using little memory and it does not take long to load rules especially if the first time just loads things like status
, level
, etc.. So let's do option 2.
One thing that might be tricky with counting the number of rules to include is that they will change depending on what the user selects. For example, if there are rules that are bothnoisy
and unsupported
and rules that are both not noisy
and unsupported
then the number of rules the user can include will change depending on whether the user chooses yes
or no
for Include noisy rules?
. This may make the logic for counting a little complex. What do you think?
@YamatoSecurity Thanks for comment. I will implement option 2. I think that it's better counting noisy and unsupported rules on first rule check.
For example, if there are rules that are bothnoisy and unsupported and rules that are both not noisy and unsupported then the number of rules the user can include will change depending on whether the user chooses yes or no for Include noisy rules?. This may make the logic for counting a little complex. What do you think?
Yes, it will be too complicated to try to dynamically count them and probably confuse users. Let's use the total count for rules based on their characteristics.
Before:
After: