Yamato-Security / takajo

Takajō (鷹匠) is a Hayabusa results analyzer.
https://yamato-security.github.io/takajo/
GNU General Public License v3.0
59 stars 4 forks source link

Deprecated usage of `spawn` in VT lookup commands #81

Open YamatoSecurity opened 6 months ago

YamatoSecurity commented 6 months ago

After updating nim to 2.0.2 with choosenim update stable I am getting the following error:

takajo-main/src/takajo.nim(15, 8) Warning: use the nimble packages `malebolgia`, `taskpools` or `weave` instead; threadpool is deprecated [Deprecated]
YamatoSecurity commented 5 months ago

@fukusuket I found the cause of this. In the three vt commands, it is causing the deprecated error due to the use of spawn from the threadpool library. Could you rewrite the parallel processing to use malebolgia instead? https://github.com/Araq/malebolgia malebolgia is written by the author of Nim so will probably be maintained in the future and seems to be suitable for our purpose.

fukusuket commented 5 months ago

@YamatoSecurity Thank you for the information! Yes, I'll try it💪