YanChii / ansible-role-postgres-ha

Create postgresql HA auto-failover cluster using pcs, pacemaker and PAF
Apache License 2.0
33 stars 22 forks source link

Resolves issues 18 and 19 adding more compatibility for Postgres 10 #20

Closed benmccown closed 5 years ago

benmccown commented 5 years ago

Details of the two commits are outlined in each relevant issue. Basically just fixing a missing hyphen and changing an outdated command switch.

YanChii commented 5 years ago

Hi @MooseBeanDev

Thank you very much for investigating the solution and sending the PR. I'll merge it ASAP. I see that you've split the role init DB dir on master if necessary to two roles according to the PG version. But there's no diferrence in actual commands (shell:). Maybe you've forgot to change something there.

Jan

benmccown commented 5 years ago

Hi @YanChii

Good catch and apologies. I had fixed it properly in the fork we have running on our locally hosted GitLab at work, but had forgot the extra hyphen in my work here. You'll see another commit now with the appropriate change added to the shell command.

Thanks, Ben

YanChii commented 5 years ago

Thank you, @MooseBeanDev

Merging.

Resolves #18 and #19