search

YanChii / ansible-role-postgres-ha

Create postgresql HA auto-failover cluster using pcs, pacemaker and PAF
Apache License 2.0
33 stars 22 forks source link

postgres_ha_paf_geo_patch no longer needed after PAF v2.2.1 release #24

Closed tamer-hassan closed 5 years ago

tamer-hassan commented 5 years ago

Thanks @YanChii , your patch was incorporated in the latest release PAF v2.2.1 https://github.com/ClusterLabs/PAF/releases/tag/v2.2.1

So maybe it would be helpful or less confusing to remove it now?

YanChii commented 5 years ago

Hi @Tamer,

Thank you for letting me know. I'll update the role to use the newest release.

But you are only partly right.

This patch is not needed anymore: https://github.com/YanChii/ansible-role-postgres-ha/blob/master/tasks/paf.yml#L26

But the GEO patch itself is not incorporated in the upstream and is still needed if you want to run pg cluster without fencing: https://github.com/YanChii/ansible-role-postgres-ha/blob/master/tasks/paf.yml#L37

Jan

tamer-hassan commented 5 years ago

@YanChii You're absolutely correct. I couldn't wait, and the changes to the pgsqlms were minimal between 2.2.0 - 2.2.1, including some that were already applied by your patch, so I easily merged the changes. Attached the patched pgsqlms in case someone is impatient (or on a deadline) like me :) p.s. I only renamed and appended file extension ".txt" to appease github's file type checking on upload. pgsqlms-2.2.1-geo-patched.txt

YanChii commented 5 years ago

Hi Tamer, thank you for your patch. I'll commit the updated version right away. Jan