search

YanChii / ansible-role-postgres-ha

Create postgresql HA auto-failover cluster using pcs, pacemaker and PAF
Apache License 2.0
33 stars 22 forks source link

Parameterize the interval? #6

Closed ioguix closed 7 years ago

ioguix commented 7 years ago

Hi,

Reading at my colleague PR #4, I discovered the monitor intervals where fixed to 15 and 16s. I suppose it would be nice to be able to set them to different values based on the cluster requirement.

https://github.com/YanChii/ansible-role-postgres-ha/blob/a3ea651544a507b44ee2d94e33d649502a157254/tasks/paf.yml#L60

Thoughts?

YanChii commented 7 years ago

Hi.

No problem, it can be easily parametrized. Parametrizing of these parameters makes sense to me: monitor_interval_master monitor_interval_slave

And maybe also a check that these two parameters are not set to the same value.

I'll take a look at it.

Jan

ioguix commented 7 years ago

And maybe also a check that these two parameters are not set to the same value.

+1, mandatory :)