Closed Mayank-Sharma17 closed 1 year ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
real-estate-frontend | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Oct 15, 2023 10:24am |
Name | Link |
---|---|
Latest commit | aa088a6a0e36ea44e1f5591dfdc23f3606ea7164 |
Latest deploy log | https://app.netlify.com/sites/symphonious-khapse-a9fcba/deploys/652bbd94421b800008e9ceb7 |
Deploy Preview | https://deploy-preview-35--symphonious-khapse-a9fcba.netlify.app/ |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@Mayank-Sharma17 Please increase the size of the buttons.
ok
@Yana-Gupta done, increased buttons size by 5px.
Add some space in between the buttons and margin in top and bottom, on smaller device please check once again the buttons are becoming completely rounded.. fix all those bugs
Also if possible avoid rounded buttons and work on making previous rectangle design responsive... cuz as per I looked previous design my much better than rounded buttons
So try making previous button responsive.
@Yana-Gupta If you want rectangular buttons, I will make them responsive and update you later, previously there is no space between buttons I have added 10px space between them do you want more space? (please tell me in px).
And the buttons are responsive for mobile views and laptop screens, but not for tablets because there is a media query for max-width 700 in 'index.scss', thus we need to add another media query for tablets, can I do that?
Please don't add any space in between the buttons
On Sat, 14 Oct, 2023, 10:02 pm Mayank Sharma, @.***> wrote:
@Yana-Gupta https://github.com/Yana-Gupta If you want rectangular buttons, I will make them responsive and update you later, previously there is no space between buttons I have added 10px space between them do you want more space? (please tell me in px).
And the buttons are responsive for mobile views and laptop screens, but not for tablets because there is a media query for max-width 700 in 'index.scss', thus we need to add another media query for tablets, can I do that?
[image: Screenshot 2023-10-14 213146] https://user-images.githubusercontent.com/113251342/275249745-34fda8e1-2f06-4f5b-a229-ea85614391ce.png
[image: Screenshot 2023-10-14 220036] https://user-images.githubusercontent.com/113251342/275256633-2ceb9f2c-59dd-45ad-af00-f1b3f7a9e6c6.png
— Reply to this email directly, view it on GitHub https://github.com/Yana-Gupta/real-estate-frontend/pull/35#issuecomment-1763034234, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYSVAFWZHAMY4DB6MYQCGPTX7K5DNAVCNFSM6AAAAAA6ACV5HWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRTGAZTIMRTGQ . You are receiving this because you were mentioned.Message ID: @.***>
Please don't add any space in between the buttons
@Yana-Gupta Done, removed the space between buttons, added margin top and bottom by 12px, changed the max-width to 960px now the buttons are also responsive for the tablets. Let me know if any changes required.
Please only improve it's responsiveness.. don't make unwanted changes with the height and width of button.
The ui doesn't look better now..
Fix all the unwanted changes..
@Yana-Gupta I apologize for any unintended changes to the height and width of the buttons that affected the UI. I removed the margin and padding from the buttons and restored the height to 80px, as it was previously.
Thanks
Improved the alignment of the buttons in the navigation bar, added a hover effect to the buttons to match the design of the website, and previously, when users switched to the mobile view, the buttons were turned into circular buttons.
Screenshots
mobile view
fix #34