YanchaoYang / FDA

Fourier Domain Adaptation for Semantic Segmentation
501 stars 81 forks source link

Why convert to BGR? #30

Closed BinhuiXie closed 3 years ago

BinhuiXie commented 3 years ago

https://github.com/YanchaoYang/FDA/blob/b9a0cdf0bcc9b787c00e39df73eda5673706f219/data/gta5_dataset.py#L57

YanchaoYang commented 3 years ago

Not so sure, I guess it is just some historical heritage from the code that we adapted.

BinhuiXie commented 3 years ago

Thank you for your replay.

wangtingwei1993 commented 3 years ago

@BinhuiXie Hi, do you know why the input image of the Fourier module must be RBG images rather than the original RGB images?

BinhuiXie commented 3 years ago

@wangtingwei1993 Actually, I have no idea. However, through practice I have found that the FFT is independent of each channel, so it is possible that any order is feasible, i.e., BGR, RGB, or RBG and etc.

Hi. @YanchaoYang. What do you think?

YanchaoYang commented 3 years ago

@wangtingwei1993 Actually, I have no idea. However, through practice I have found that the FFT is independent of each channel, so it is possible that any order is feasible, i.e., BGR, RGB, or RBG and etc.

Hi. @YanchaoYang. What do you think?

Yes, the order does not affect FDA, or the adaptation performance, it only affects the final visualization I guess.