⌘I "About" tab is broken with overflown Input Sources

Yang-Xijie / InputSourceSwitcher

A menu bar app to swiftly change input sources using shortcuts on macOS Big Sur. [Swift+SwiftUI] NO LONGER MAINTAIN

MIT License

36 stars 6 forks source link

⌘I "About" tab is broken with overflown Input Sources #7

Closed GJRobert closed 3 years ago

GJRobert commented 3 years ago

First of all, applause for this new method to switch input sources without irritation! Kawa has add a forced "Switching to US first" method to overcome CJKV problem, but Source Switcher is doing more neatly.

This is the only graphical glitch I have found:

Steps to reproduce:

Press About in the main dropdown menu of Source Switcher
The space above the introduction of the app is broken by too many input sources (I have 15...)
⌘I toggles between the broken view and the main menu

Yang-Xijie commented 3 years ago

Currently, I fix the max input sources to six, for I don't think one could use more than six input sources. This make the menu bar app have a simple layout.

Maybe sometime I will consider about it. Or pull requests are welcome!

Yang-Xijie commented 3 years ago

https://github.com/Yang-Xijie/InputSourceSwitcher/blob/10906df7dd16eedcdb095954c769eba9657ae1c7/InputSourceSwitcher/App/ContentView.swift#L20

If you want to change the frame height, just change the concerning codes, and rebuild the app by yourself.

Yang-Xijie commented 3 years ago

https://github.com/Yang-Xijie/InputSourceSwitcher/blob/91af6aead7f9c4a20be02f2a60c05d4cdbe77e46/InputSourceSwitcher/App/ContentView.swift#L12-L22

Thanks for your report! I have fixed this issue in version 1.1 (5) and you can download the app from the release page.

https://github.com/Yang-Xijie/InputSourceSwitcher/releases/tag/v1.1

GJRobert commented 3 years ago

Thank you so much for your kind help! This is such a great tool! I have just composed a short introduction onto the Mac board on PTT.cc.