YangCatalog / backend

YANG Catalog's REST API and internal module processing pipeline
https://yangcatalog.org
Apache License 2.0
2 stars 11 forks source link

Fix organizations #737

Closed bskqd closed 1 year ago

bskqd commented 1 year ago

I removed IANA from organizations but left it in sdos because it was in sdos even before this PR: https://github.com/YangCatalog/backend/pull/729, I also searched for mef modules on PROD and it seems like there are no such modules with 'independent' organization, organizations set either to ietf or mef, should we change it to mef everywhere?

NOTE: In grep search, I assumed that modules names started with the organization name should have this organization (so iana-... modules have iana organization), but as it's not the case I removed this functionality

resolves #733

codecov[bot] commented 1 year ago

Codecov Report

Merging #737 (6dd9839) into develop (3518565) will decrease coverage by 0.01%. The diff coverage is 100.00%.

:exclamation: Current head 6dd9839 differs from pull request most recent head 29ee687. Consider uploading reports for the commit 29ee687 to get more accurate results

@@             Coverage Diff             @@
##           develop     #737      +/-   ##
===========================================
- Coverage    77.74%   77.73%   -0.01%     
===========================================
  Files          114      114              
  Lines        12296    12293       -3     
===========================================
- Hits          9559     9556       -3     
  Misses        2737     2737              
Impacted Files Coverage Δ
api/views/yangSearch/grep_search.py 92.85% <100.00%> (-0.19%) :arrow_down:
tests/test_search.py 100.00% <100.00%> (ø)
utility/staticVariables.py 100.00% <100.00%> (ø)
richardzilincikPantheon commented 1 year ago

organizations set either to ietf or mef, should we change it to mef everywhere?

Probably, it should be consistent in some way at least. Could you show an example where the organization is set to ietf?

richardzilincikPantheon commented 1 year ago

I removed IANA from organizations but left it in sdos because it was in sdos even before this PR

The list of SDOs is meant to be a subset of the organizations, just to check if a specific organization is an SDO. I think it's only used for ES. Since there are no modules with their organization set to iana, we won't ever need to check if iana is an SDO. It staying there won't make any functional difference.

bskqd commented 1 year ago

organizations set either to ietf or mef, should we change it to mef everywhere?

Probably, it should be consistent in some way at least. Could you show an example where the organization is set to ietf?

Sorry, I wasn't right, I only found this module with ietf organization: https://yangcatalog.org/yang-search/module_details/ietf-l1-mef-service-types@2019-06-20, but it doesn't start with mef, so it's okay, it seems like all the mef modules have mef organization

bskqd commented 1 year ago

organizations set either to ietf or mef, should we change it to mef everywhere?

Probably, it should be consistent in some way at least. Could you show an example where the organization is set to ietf?

Thanks, I removed iana from sdos