YangCatalog / module-compilation

Tools to collect, extract, and validate YANG modules
https://yangcatalog.org/private-page
Apache License 2.0
0 stars 5 forks source link

Old YANG modules that don't follow the example-xx convention should not be taken into account #20

Closed bclaise closed 5 years ago

bclaise commented 5 years ago

This email was generated.

Hello from yang-catalog

Some of the files are different in https://yangcatalog.org/private/IETFYANGRFC.json against yangModels/yang repository

Files that are missing in yangModels/yang repository: ct-ipfix-psamp-example.yang

Files that are different than in yangModels repository: iana-if-type.yang ietf-l3vpn-svc.yang .

ct-ipfix-psamp-example.yang should not appear in the log.
It should not even be inspected.
I had this function in my old code.

def move_old_examples_YANG_modules_from_RFC(path, path2, debug_level):
     """
     Move some YANG modules, which are documented at
http://www.claise.be/IETFYANGOutOfRFCNonStrictToBeCorrected.html:
     ietf-foo@2010-01-18.yang, hw.yang, hardware-entities.yang,
udmcore.yang, and ct-ipfix-psamp-example.yang
     Those YANG modules, from old RFCs, don't follow the example-
conventions
     :param path: the path where to remove the YANG modules
     :return: none
     """
     for y in ["ietf-foo@2010-01-18.yang", "hw.yang",
"hardware-entities.yang", "udmcore.yang",
"ct-ipfix-psamp-example@2011-03-15.yang", "example-ospf-topology.yang"]:
         bash_command = "mv " + path + y + " " + path2 + y
         temp_result = os.popen(bash_command).read()
         if debug_level > 0:
             print("DEBUG: " + "
move_old_examples_YANG_modules_from_RFC: error " + temp_result)

Can you please take care of this issue.
Do you want me to open a github issue, for tracking purposes.

Regards, Benoit
miroslavKovacPantheon commented 5 years ago

The best would be to create a json file that would contain list of unwanted modules since this list might change and it would be easier to maintain that way.