YangCatalog / module-compilation

Tools to collect, extract, and validate YANG modules
https://yangcatalog.org/private-page
Apache License 2.0
0 stars 5 forks source link

Added in progress status to job log #251

Closed bskqd closed 1 year ago

bskqd commented 1 year ago

Added "In Progress" status to job logs, created a separate job log enum with all the statuses, and added the job_log function call to other scripts.

resolves #250 resolves #252

github-actions[bot] commented 1 year ago

Coverage report

Full coverage report summary (click to unfold) check_archived_drafts.py: 91%
create_config.py: 100%
extractors/__init__.py: 100%
extractors/draft_extractor.py: 67%
extractors/extract_elem.py: 77%
extractors/helper.py: 44%
figures_and_stats/__init__.py: 100%
figures_and_stats/yang_get_stats.py: 90%
ietf_modules_extraction/__init__.py: 100%
ietf_modules_extraction/gather_ietf_dependent_modules.py: 81%
ietf_modules_extraction/yang_version_1_1.py: 72%
job_log.py: 77%
main_page_generation/__init__.py: 100%
main_page_generation/private_page.py: 52%
message_factory/__init__.py: 100%
message_factory/message_factory.py: 26%
metadata_generators/__init__.py: 100%
metadata_generators/extract_emails.py: 67%
modules_compilation/__init__.py: 100%
modules_compilation/file_hasher.py: 90%
parsers/__init__.py: 100%
parsers/yang_parser.py: 65%
redis_connections/__init__.py: 100%
redis_connections/constants.py: 100%
redis_connections/redis_connection.py: 96%
redis_connections/redis_user_notifications_connection.py: 61%
rename_file_backup.py: 78%
tests/test_check_archived_drafts.py: 96%
tests/test_extract_elem.py: 96%
tests/test_extract_emails.py: 94%
tests/test_file_hasher.py: 98%
tests/test_gather_ietf_dependent_modules.py: 98%
tests/test_get_stats.py: 97%
tests/test_private_page.py: 100%
tests/test_remove_directory_content.py: 98%
tests/test_rename_file_backup.py: 97%
tests/test_utility.py: 100%
tests/test_yang_version_1_1.py: 97%
utility/__init__.py: 100%
utility/static_variables.py: 100%
utility/utility.py: 85%
versions.py: 100%

The coverage rate went from 83.62% to 83.37% :arrow_down:

74.13% of new lines are covered.

Diff Coverage details (click to unfold) ### figures_and_stats/yang_get_stats.py `100%` of new lines are covered (`90.15%` of the complete file). ### job_log.py `76.47%` of new lines are covered (`77.77%` of the complete file). Missing lines: `108`, `111`, `112`, `113`, `119`, `121`, `122`, `124` ### check_archived_drafts.py `100%` of new lines are covered (`91.66%` of the complete file). ### ietf_modules_extraction/gather_ietf_dependent_modules.py `0%` of new lines are covered (`81.57%` of the complete file). Missing lines: `67` ### tests/test_check_archived_drafts.py `81.81%` of new lines are covered (`96.73%` of the complete file). Missing lines: `87`, `88` ### ietf_modules_extraction/yang_version_1_1.py `42.85%` of new lines are covered (`72%` of the complete file). Missing lines: `73`, `95`, `96`, `98`
bskqd commented 1 year ago

Base your branches on develop whenever possible.

I do but just didn't want to resolve possible conflicts due to moving code out of the bin directory

SlavomirMazurPantheon commented 1 year ago

I would prefer to not log individual scripts as extract_ietf_modules, gather_ietf_dependent_modules ...., but log only start/end of cronjob-daily script and these individual scripts can be added as Additional information, so it will look more like this Image Pasted at 2023-1-13 08-44

bskqd commented 1 year ago

I would prefer to not log individual scripts as extract_ietf_modules, gather_ietf_dependent_modules ...., but log only start/end of cronjob-daily script and these individual scripts can be added as Additional information, so it will look more like this Image Pasted at 2023-1-13 08-44

done Screenshot from 2023-01-13 18-58-57 Screenshot from 2023-01-13 19-01-29