Closed bskqd closed 1 year ago
The coverage rate went from 83.46%
to 83.52%
:arrow_up:
100%
of new lines are covered.
I also thought of doing it this way at first, but it occurred to me that maybe we want to have the data for the different versions of the file in the html/json reports. For example here https://yangcatalog.org/private/CiscoXR672YANGPageCompilation.html at the top of the page we claim that these are results for modules in https://github.com/YangModels/yang/tree/main/vendor/cisco/xr/672/, which might not be the case anymore. I don't really know which is better though, this also makes sense in a different way and is probably fine too.
I also thought of doing it this way at first, but it occurred to me that maybe we want to have the data for the different versions of the file in the html/json reports. For example here https://yangcatalog.org/private/CiscoXR672YANGPageCompilation.html at the top of the page we claim that these are results for modules in https://github.com/YangModels/yang/tree/main/vendor/cisco/xr/672/, which might not be the case anymore. I don't really know which is better though, this also makes sense in a different way and is probably fine too.
Oh, I see, not sure what will be the right choice in this situation, @SlavomirMazurPantheon what do you think about it?
P.S. I believe it's better to keep it as it is implemented now, so we have the same data in Redis and compilation files
Running the
compile_modules.py
script again after a run of thepopulate.py
script will not help because statistics and other generated files won't be overwritten because of lack of information for them (or managing their upload will not be straightforward at all as we have to manage different ietf arguments and they all have specific logic), so I decided to check the/var/yang/all_modules
directory inside thecompile_modules.py
script, so if the file is already in the/var/yang/all_modules
and the hash of the file that is being processed at the moment is different from the hash of the file inside the/var/yang/all_modules
, we will compile the file from the/var/yang/all_modules
dir, as it's always the actual file. I didn't remove updating of Redis from thecompile_modules.py
script because if this case happens, then the actual compilation data will be set to Redis after the next run ofcompile_modules.py
resolves #248