YangLab-um / BiologicalOscillations.jl

A package for researchers working with biological oscillations
https://yanglab-um.github.io/BiologicalOscillations.jl/
MIT License
1 stars 2 forks source link

Can't customize run via `find_pin_osicllations` (`find_grn_oscillations`) #23

Closed ftavella closed 9 months ago

ftavella commented 10 months ago

The current implementation does not allow the user to select the following hyperparameters in find_pin_oscillations (find_grn_oscillations):

Possible solution

Add a hyperparameters input to find_pin_oscillations where the user can pass a dictionary with hyperparameters of their choosing. If they are present in the dictionary, use the provided values. If not use the default hyperparameters. It might help defining a package-wide DEFAULT_HYPERPARAMETERS dictionary that provides these values for the whole package.

ftavella commented 10 months ago

We were thinking about adding a new input variable like

find_pin_oscillations(connectivity, samples, initial_conditions, hyperparameters=DEFAULT_HYPERPARAMETERS)

However, we want users to be able to define some of the hyperparams. We will need a function that combines what the user provides with the default values.

ftavella commented 9 months ago

Functions affected by this change: