search

YangLab-um / BiologicalOscillations.jl

A package for researchers working with biological oscillations
https://yanglab-um.github.io/BiologicalOscillations.jl/
MIT License
1 stars 2 forks source link

Solve Issue #23 #27

Closed ftavella closed 9 months ago

ftavella commented 9 months ago

This PR solves #23. It implements a hyperparameters parameter to find_oscillations for both pin and grns. It also creates a grn_hit_rate function for further developments on the grn part of the package.

Finally, pin tests are updated and some drafted for future development as well. Most importantly, the CI now tests find_pin_oscillations which will ensure that all future changes are consistent.

ftavella commented 9 months ago

@biphy Finally the tests are within a reasonable bound! Ready for review

biphy commented 9 months ago

Looks nice, this will be merged!