search

YangModels / yang

YANG modules from standards organizations such as the IETF, The IEEE, The Metro Ethernet Forum, open source such as Open Daylight or vendor specific modules
1.52k stars 1.2k forks source link

yc.o sync #1591

Closed xorrkaz closed 2 weeks ago

einarnn commented 1 month ago

@xorrkaz, there are a bunch of errors in the IETF content. Will you be looking at those?

xorrkaz commented 1 month ago

I am watching. The problem is missing IANA modules. The IANA sync job is running, and I saw one leak out recently. I don't know why the rest are not. If they don't get pushed before 121, I'll spend some time there sorting it.

xorrkaz commented 1 month ago

Ah, actually, I lied @einarnn. The modules do exist in the repo. Your search path is wrong. The IANA modules are spread between extracted and standard, but the search path in the failing job is /home/runner/work/yang/yang/standard/ieee/published/. Can you expand the path to cover all module locations?

xorrkaz commented 1 month ago

I think the ietf check.sh script needs something IANA-focused akin to:

ieee_dir_flag="--path $cwd/$ieee_dir/published/"

Such as:

iana_dir="standard/iana"
iana_dir_flag="--path $cwd/$iana_dir/"
pyang_flags="--verbose $ieee_dir_flag $iana_dir_flag"

That won't fix all of the issues right now. But it seems like IANA is lagging a bit in tracking drafts turning into RFCs. I think they will eventually all work.

einarnn commented 4 weeks ago

@xorrkaz, it would be better if whoever is committing changes that broke the check scripts als fixed the check scripts as part of their commit. Was this broken by this commit or by a different one?

xorrkaz commented 3 weeks ago

It's not a question of a commit. The IANA modules are now automatically updated in their own directory. My other PR fixed looking for those. However, in the case of these IANA SSH modules, their repo still refers to the drafts and not the RFCs. Therefore, they aren't being added to the standard/iana directory. I'll try and figure out when/how those get updated with IANA while I'm at the 121 meeting.

xorrkaz commented 2 weeks ago

I spoke with Sabrina from IANA, and she said the SSH modules are pending a review from Kent Watsen. Once that clears, they should be fully published, and the pyang parsing should succeed.