YannickB / odoo-hosting

Other
64 stars 50 forks source link

[IMP] Migrate to v10 #145

Closed lasley closed 7 years ago

lasley commented 7 years ago

Depends:

lasley commented 7 years ago

@YannickB - How important is it to keep async activated during incubator? I would like to deactivate it so that we can move up to 10.

Reason being - there are methods existing in the new model API that will make things much more efficient. I'd like to start knocking them out, because they'll be easier to back-port due to broken CI than to forward-port due to having to re-audit.

YannickB commented 7 years ago

Now that we moved async out of the core it's completely optional and I don't think we'll use it before long. You can deactivate.

lasley commented 7 years ago

Sweet! Admittedly also I'm just getting tired of having to click the stupid arrow in the M2O fields. v10 you can click anywhere and it pains me to move five millimeters to the right during the setup of things

YannickB commented 7 years ago

Ahah, well we have to move to v10 anyway.

codecov-io commented 7 years ago

Current coverage is 30.98% (diff: 96.03%)

Merging #145 into master will decrease coverage by 0.09%

@@             master       #145   diff @@
==========================================
  Files            73         72     -1   
  Lines          5666       5626    -40   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           1761       1743    -18   
+ Misses         3905       3883    -22   
  Partials          0          0          

Powered by Codecov. Last update 24e560c...2cc9348

lasley commented 7 years ago

Alright this looks to work just by the simple upgrade regexes! I love it when that happens, although we'll probably find some errors here and there just due to lack of test coverage.

You can do a functional test using this Runbot.

YannickB commented 7 years ago

Great :), ready to merge then ?

lasley commented 7 years ago

Yup!