YannickB / odoo-hosting

Other
64 stars 50 forks source link

[IMP] Add support for Libcloud #160

Closed YannickB closed 7 years ago

YannickB commented 7 years ago

This PR add support for Libcloud and allow to create an instance on the cloud (like Amazon) directly from the Clouder interface after filling credentials.

Tested with free amazon instance.

Two bugs I was not able to resolve (it's Odoo related bug, not libcloud) : -The state of the instance is not displaying -Same for size and location, they are not working correctly, that's why there is hard-coded values now. We can fix theses bugs in another PR to avoid immediate functional review.

YannickB commented 7 years ago

Ok I have trouble, I can't make travis go green because it can't see libcloud. Maybe because the name of the package (apache-libcloud) is not the same than import (libcloud). Any idea ?

codecov-io commented 7 years ago

Current coverage is 29.68% (diff: 43.15%)

Merging #160 into master will increase coverage by <.01%

@@             master       #160   diff @@
==========================================
  Files            72         71     -1   
  Lines          5411       5488    +77   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1606       1629    +23   
- Misses         3805       3859    +54   
  Partials          0          0          

Powered by Codecov. Last update b9caaf1...fd02ccc

YannickB commented 7 years ago

Looks like I found a workaround. Ready for review.

lasley commented 7 years ago

Woot yup the python-depends is what the import is. I swear that gets me so much, because it's totally backwards in comparison to setuptools or pip requires.

YannickB commented 7 years ago

Ready for review

lasley commented 7 years ago

@t3ddftw please review

YannickB commented 7 years ago

Ok then, just merging recent commit from master and if everyone is okay let's merge it.

YannickB commented 7 years ago

All checks ok and I suppose everybody agree, I'm merging