search

YannickB / odoo-hosting

Other
64 stars 50 forks source link

[REF] Replace import odoo by try catch #203

Closed YannickB closed 7 years ago

YannickB commented 7 years ago

Replacing all import odoo by try catch and import openerp otherwise.

I know this is gonna be a bother and will not make everyone happy, but it's too soon for me to drop support for Odoo8/Odoo9. Still, I agree that when we release Clouder 0.10 we should only support Odoo10.

codecov-io commented 7 years ago

Current coverage is 31.57% (diff: 100%)

Merging #203 into master will increase coverage by 0.56%

@@             master       #203   diff @@
==========================================
  Files            73         73          
  Lines          5653       5700    +47   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1753       1800    +47   
  Misses         3900       3900          
  Partials          0          0

Powered by Codecov. Last update d5ccfab...8e34ddf

lasley commented 7 years ago

This saddens me - changes like this make repos gigantic 😦 . I guess maybe we can squash when we bring into OCA or something?

This looks fine code-wise if you feel it's necessary. I'm known for leaving older clients in the dust with no care, so my opinion probably isn't worth much in this regard 😛

YannickB commented 7 years ago

We'll keep this until we don't have any need for older version of Odoo. Ok merging!