Open katyukha opened 7 years ago
Merging #227 into master will increase coverage by
0.11%
. The diff coverage is0%
.
@@ Coverage Diff @@
## master #227 +/- ##
==========================================
+ Coverage 33.16% 33.28% +0.11%
==========================================
Files 52 52
Lines 3902 3888 -14
==========================================
Hits 1294 1294
+ Misses 2608 2594 -14
Impacted Files | Coverage Δ | |
---|---|---|
clouder/ssh/environment.py | 27.52% <ø> (+0.97%) |
:arrow_up: |
clouder/models/model.py | 23.15% <0%> (+0.53%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8b9c75b...5110400. Read the comment docs.
Hello!
This is mostly bugfix PR, but I want also do some more refactoring of
__execute
method. Can I do it in this PR? Or it is better to create separate PR?Changes
ClouderModel.__execute
SSHEnvironment.__getattr__
: if we define getattr we do not need to call super method, because getattr is called only if attribute is not found by other methods, such as: dict lookup, getattribute, etc.Plans
ClouderModel.__execute
_execute
, this allow to override it in inherited models, especiallycolouder.service
ClouderService
toclouder.service
model (this allow to avoid strange ifs likeif self._name == 'clouder.service'
)cmd
arg to separate method