Templated the yml file in a way it's usable and can be referred elsewhere

YannickRe / azuredevops-buildagents

Generate self-hosted build agents for Azure DevOps, just like Microsoft does.

MIT License

151 stars 90 forks source link

Templated the yml file in a way it's usable and can be referred elsewhere #16

Closed ddprince-pro closed 2 years ago

ddprince-pro commented 2 years ago

Instead of copying the yml files of this repository, we opted on reusing it via a resource inclusion within Azure DevOps. That way, we simply need to include the template in the following manner when we want to use it:

It also allows us to include additional steps before and after this template. I hope you like it. If not, simply let us know and we'll cancel this PR :)

Thank you!

YannickRe commented 2 years ago

First of all, thank you for the PR! I very much appreciate it.

I think I understand the changes that you made, even though this is now starting to get outside of my league 😀. What I can't assess yet is the impact these changes will have on pipelines that don't do the including (like you) but are running standalone, especially given that you removed the trigger: none declaration.

I will need to inject your changes in our current pipeline and see if it breaks something. If not, I am more than happy to accept the PR. It might take a while to get to it, but I will for sure not forget!

ddprince-pro commented 2 years ago

Cool! If you face an issue with this new version under your pipeline, just le me know, I will surely be able to do further slights adjustments to make sure it also works under your scenario.

ddprince-pro commented 2 years ago

Closing this in favor of #17 , since we want to continue our development on main without affecting this PR.