search

YannickRe / azuredevops-buildagents

Generate self-hosted build agents for Azure DevOps, just like Microsoft does.
MIT License
151 stars 90 forks source link

Adjusted buildagent-generation-template.yml to work with new actions/running-images image directory structure. #71

Closed erik-de-bont closed 10 months ago

erik-de-bont commented 11 months ago

New build buildagent-generation-template.yml to solve issue lhttps://github.com/YannickRe/azuredevops-buildagents/issues/70. During the transition period of the actions/runner-images repository of migrating to the new directory image structure the script can only be used for alpha images. The old script (renamed buildagent-generation-template-old ) should be use for pre-production and production image during this transition period.

devneutz commented 11 months ago

It seems in the meantime they also changed the folder structure for the release images: https://github.com/actions/runner-images/pull/8627/

erik-de-bont commented 11 months ago

It seems in the meantime they also changed the folder structure for the release images: https://github.com/actions/runner-images/pull/8627/

That should mean than images created after November 15th have now a production status. Hopefully @YannickRe has time to merge my pull request, which should work with the new file structure. I have currently tested it in two enviroments. In both I was able to generate new Windows and Linux runner images.

erik-de-bont commented 11 months ago

Hi Erik, why did you keep an old file?

At first only the alpha version was using the new structure, but the pre-release and release were using the old structure. So we are in a transition fase. I have removed it now.

pippolino commented 11 months ago

At first only the alpha version was using the new structure, but the pre-release and release were using the old structure. So we are in a transition fase. I have removed it now.

The release version also uses the new structure.

I'm trying your version and for now it works for ubuntu. I'll also try it for Windows.

YannickRe commented 11 months ago

@erik-de-bont thank you for the work. Is there a specific reason you switched to using the build-image.ps1 and measure-provisioners-duration.ps1 from the runner-images repo and not the one included in this repo? I'm trying to assess what the risk is with switching to the one from MS vs staying with the one I had here originally.

erik-de-bont commented 11 months ago

@YannickRe No, there is no specific reason. I just looked at the action/runner-images code and modified the scripts to make it work again with the new action/runner-images code.

erik-de-bont commented 10 months ago

Due to a change in the actions/runner-images repo, the templates have been changed from *.json to pkr.hcl format for the alpha releases.. At the moment of writing this comment the pre-release and release are still using the json format. It usually takes 2-4 weeks before the alpha images become release, so we are again in a transition period.

YannickRe commented 10 months ago

@erik-de-bont thanks for all the work! I do not require more information, I have been working long hours to go-live with my project. Soon I'll take 4 weeks vacation, and your work is the highest on my list to get out the door.

I'm sorry for the lack of interaction.

YannickRe commented 10 months ago

@erik-de-bont I finally got around to testing and merging it today. Thank you for all the hard work!