YannickRe / spfx-msgraph-peoplesearch

Show and search users from your organization with an SPFx web part, through Microsoft Graph.
40 stars 33 forks source link

Support for python3 #15

Closed MMAtHome closed 3 years ago

MMAtHome commented 3 years ago

I see an error during npm install that says the code is looking for python2. I'm pretty new to this so it may be a configuration issue. If you have any pointers, that would be great or do you have a code branch that supports python3?

YannickRe commented 3 years ago

@MMAtHome Mind sharing the references you are seeing to Python? This code does not use Python as a direct dependency, but it might be something that the SharePoint Framework uses under the covers.

MMAtHome commented 3 years ago

Thanks for responding so quickly. I am pretty new to this so let me first tell you the steps I went through.

  1. Cloned the repository to a local setup on my WIndows 10 machine
  2. Opened a command window
  3. Went to the directory containing the cloned repository
  4. Ran npm install

It was during the npm install process that the error was generated.

I am thinking that this is probably a local environmental issue as I have cloned another project this morning and attempted to run npm install on that with pretty much the same error. Command failed: C:\Python39\python.EXE -c import sys; print "%s.%s.%s" % sys.version_info[:3] Everything after this point seems to be a problem from the above.

I'm happy to persevere with this but do you have a pre-built SharePoint package that you could share with me?

On Tue, Feb 9, 2021 at 1:44 PM Yannick Reekmans notifications@github.com wrote:

@MMAtHome https://github.com/MMAtHome Mind sharing the references you are seeing to Python? This code does not use Python as a direct dependency, but it might be something that the SharePoint Framework uses under the covers.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/YannickRe/spfx-msgraph-peoplesearch/issues/15#issuecomment-775946359, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASZD3XLGGAN64TYZWPZLLCLS6E34JANCNFSM4XKSXKFA .

YannickRe commented 3 years ago

Ok, it is starting to make sense to me. I "think" you don't have your computer set up for SharePoint Framework development yet, the information can be found on https://docs.microsoft.com/en-us/sharepoint/dev/spfx/set-up-your-development-environment?WT.mc_id=M365-MVP-5003400 This will install some global prerequisites, after which you can run npm install in this project and you shouldn't be getting the Python error anymore.

It's a conscious decision to not release a pre-built package, as it infers some support from my side and there is no support. The only support I give is through this issue list when time permits me. Also, second thing: with a pre-built package you aren't sure what you are putting in your environment and have to trust a bit that I do nothing malicious.

MMAtHome commented 3 years ago

Thank you very much for your comments and guidance. I will get all the prerequisites installed and let you know how it goes. Best regards Martin

On Tue, Feb 9, 2021 at 2:56 PM Yannick Reekmans notifications@github.com wrote:

Ok, it is starting to make sense to me. I "think" you don't have your computer set up for SharePoint Framework development yet, the information can be found on https://docs.microsoft.com/en-us/sharepoint/dev/spfx/set-up-your-development-environment?WT.mc_id=M365-MVP-5003400 This will install some global prerequisites, after which you can run npm install in this project and you shouldn't be getting the Python error anymore.

It's a conscious decision to not release a pre-built package, as it infers some support from my side and there is no support. The only support I give is through this issue list when time permits me. Also, second thing: with a pre-built package you aren't sure what you are putting in your environment and have to trust a bit that I do nothing malicious.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/YannickRe/spfx-msgraph-peoplesearch/issues/15#issuecomment-776000034, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASZD3XJHUZOLFUEGRREQZRLS6FEKHANCNFSM4XKSXKFA .

YannickRe commented 3 years ago

Happy to help out in any way if you get stuck somewhere.

MMAtHome commented 3 years ago

Thanks again for your help.

On Tue, Feb 9, 2021, 15:49 Yannick Reekmans notifications@github.com wrote:

Happy to help out in any way if you get stuck somewhere.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/YannickRe/spfx-msgraph-peoplesearch/issues/15#issuecomment-776039676, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASZD3XNHL5YXGD7ZSTWLQYTS6FKRTANCNFSM4XKSXKFA .

MMAtHome commented 3 years ago

Hey Yannick,

I'm sorry to bother you again but I think I am really close to the deployment working. I have run all commands, deployed the package to my tenant and run the relevant grant from m365 spo. In SharePoint, I can add the web part but I get the message below

AADSTS65001: The user or administrator has not consented to use the application with ID '5675beda-b8a3-40de-a290-8cf4b3117be8' named 'SharePoint Online Client Extensibility Web Application Principal'. Send an interactive authorization request for this user and resource. Trace ID: 1eaff9ae-9795-49ea-935b-25f5f3a6a600 Correlation ID: 16036007-5ffe-49f7-a890-f9658adf3570 Timestamp: 2021-02-16 17:28:08Z

I've located the app in AAD admin centre and given permissions as below to a few users to see if I can get this to work but no luck

[image: image.png]

Any ideas would be appreciated.

Very best regards,

Martin

On Mon, Feb 15, 2021 at 9:44 AM Yannick Reekmans notifications@github.com wrote:

Closed #15 https://github.com/YannickRe/spfx-msgraph-peoplesearch/issues/15.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/YannickRe/spfx-msgraph-peoplesearch/issues/15#event-4330801248, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASZD3XPGKVCUXE6YCIWIT6TS7DUJJANCNFSM4XKSXKFA .

MMAtHome commented 3 years ago

Apologies - I found the issue - it seems that my m365 spo command did not run correctly so I had to update the required permissions manually in AAD. Thanks again Martin

On Mon, Feb 15, 2021 at 9:44 AM Yannick Reekmans notifications@github.com wrote:

Closed #15 https://github.com/YannickRe/spfx-msgraph-peoplesearch/issues/15.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/YannickRe/spfx-msgraph-peoplesearch/issues/15#event-4330801248, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASZD3XPGKVCUXE6YCIWIT6TS7DUJJANCNFSM4XKSXKFA .

YannickRe commented 3 years ago

Good job!