search

YannickRe / spfx-msgraph-peoplesearch

Show and search users from your organization with an SPFx web part, through Microsoft Graph.
40 stars 33 forks source link

Problem with VIVA in Teams Desktop App #35

Closed aknueppel closed 5 months ago

aknueppel commented 2 years ago

We host a modern SharePoint site in SharePoint Online with your Peoplesearch web part. There is no problem when I use a browser to view the sharepoint site. We have integrated the site with the new MS VIVA app into teams. And there is the problem. Teams Web shows the web part, but the Teams desktop app (Windows) often shows a red bar with an x at the beginning. Most of the time when I hit update it works.

I imagine it could be a timing issue. When Teams opens, there is a lot of work to do in the background and there is a delay in displaying the web part. This would also be supported by the fact that a PC that is very slow does not manage to display the web part in Teams (desktop app), but in the browser (teams.microsoft.com) it does.

This is what it looks like in the Teams desktop app

image

patricklee-sharepoint commented 2 years ago

I have the same problem. Based on debugging, it fails on getting OnBehalfof(OBO) Token. Is there any update on the fix?

YannickRe commented 2 years ago

I'm sorry but this is an SPFx internal issue and nothing I can do about it. It has to do with the MSAL version SPFx is using internally, and some issues that exist in the Teams desktop client. After a refresh it normally starts working. I'll ping someone in MS again.

YannickRe commented 2 years ago

@aknueppel @patricklee-sharepoint Are you using the Viva Connections app where you create your own app package with PowerShell or the new first party app that you configure in the Teams Admin Center?

patricklee-sharepoint commented 2 years ago

@YannickRe the app was created from Microsoft app in Teams admin centre app list.

YannickRe commented 2 years ago

@patricklee-sharepoint MS asks if you have visited API access page in SharePoint Tenant Admin with a Global Administrator account in the last 3 to 4 weeks? If not, could you tell me and also try this and see if this fixes your issue?

If it does not, they'd like to take a look at your tenant 😀

aknueppel commented 2 years ago

@YannickRe We use the MS PS Skript https://docs.microsoft.com/de-DE/sharepoint/viva-connections#prepare-for-viva-connections-desktop-and-viva-connections to create the Viva app.

And about your second question: No, we never check the SharePoint API access page in sharepoint directly. But now I've made up for that. I'll check if that helped.

YannickRe commented 2 years ago

@aknueppel There is also the OOTB VIva Connections app that you can go rebrand in the Teams Admin center, which offers more functionality than the one you create through PowerShell. Could you maybe try that one and see if you still have the error there too?

YannickRe commented 5 months ago

Closing this. Can no longer reproduce this and in the meantime, this web part, the Teams mobile app, and SharePoint have gotten various updates. If this issue still persists, feel free to open a new issue.