YannickRe / spfx-msgraph-peoplesearch

Show and search users from your organization with an SPFx web part, through Microsoft Graph.
40 stars 33 forks source link

WebPart Settings: not visible after adding to page with pnp-modern-search webpart #54

Closed Id10tSupport closed 2 years ago

Id10tSupport commented 2 years ago

Describe the bug Same as bug reported in pnp-modern-search issues list

To Reproduce This time, I created a new Team site and a new Communication site in my test tenant. -- looking to see if there was an issue with the site or the Site Pages library. Created a new Site Page in both, then added the People Search webpart (after updating to the current version in the app catalog). Published the page, refreshed, and then edited the page. Could see the settings just fine. Added the pnp-modern-search webpart, published the page and refreshed. Went back into edit and now the setting for the people search are blank.

Occasionally get a message in the settings pane: "No settings available. The web part or dashboard card using this property pane was deleted."

Expected behavior Settings should be visible for webpart when editing the page

Screenshots image

YannickRe commented 2 years ago

I was able to reproduce it. It happens because I was using react-ace 9.5.0 (the latest) and PnP Modern Search uses an older version, and this creates conflicts with both components loaded on the page. It's also described at https://github.com/microsoft-search/pnp-modern-search/issues/407

As a temporary solution, I released v2.7.0 where I downgraded my web part to the same version as PnP Modern Search. This also resolves https://github.com/microsoft-search/pnp-modern-search/issues/1964

Id10tSupport commented 2 years ago

Tested and verified as working!! Thanks for the quick fix!!