Closed rasbt closed 2 years ago
Have you tried running the code?
No, the code generally doesn't work on my computer (getting import errors with the logger). Looking at it carefully, I can't see an issue with the fix. It should run ok.
Fixed it in the example code so that it can be tested by the CI workflow
Thanks!
I don't think there should be a softmax in the output layer if you use
CrossEntropyLoss
since CrossEntropyLoss takes logits as inputs (and performs aLogSoftmax
internally): https://pytorch.org/docs/stable/generated/torch.nn.CrossEntropyLoss.html.