Rubric Code

[Miriampion]

	0 points	1 points	2 points	3 points
Accessibility	No considerations	Added some alt attributes, nothing else	Just the basics: alt attributes, roles	Accessibility is well considered and tested
Code quality	Barely started	Indentation is barely existent, lots of validation errors, very poor semantics	Decent indentation, just a couple validation errors, decent semantics	Well indented, fully valid, good semantics
Performance	Chugging slowly like molasses on a cold day	Takes a few seconds to load, some things do not load	Ok, with a few slow images	Really fast, super fast
Commit quality	Barely any commits	A few commits but they make no sense	Good commits but really not enough	Lots of good descriptive commits
Code deduplication & maintainability	Complete mess	Duplication, copies and duplication	A few duplications, but pretty easy to understand	No duplication, easy to manage and navigate
Critiques from peers	Total chaos, even lost a few friends	Liked it but were a bit confused and accessibility didn't work	Good reception but a few questions and improvements needed	Whoo Hoo made new friends, and they want to buy this app

[sander-aaron]

Accessibility - 3

All of us have tabbed through the site and were able to navigate all the pages. The colours have enough contrast that they are readable to anyone with a visual impairment. We have tested the accessibility on all fronts and feel confident that the site is accessible.

Code quality - 3

We think that our code quality is very good. Even though all three of us have different strengths we all worked together to make sure the code is complete, uniform and that it works properly.

Performance - 2

It's kinda slow since all of our pages have a background image and all our "modules" are different pages.

Commit quality - 3

Our commits were descriptive and well written. They were helpful at describing what had been done in the pull request when the reviewer was looking it over.

Code duplication & maintainability - 2

We have a bit of overlap in our code, our buttons are pretty much all the same but are still separate patterns. We could have created MD files or a single pattern and filled in everything but it was just easier to have separate files with specific links and aria-labels. Everything else, it good, there is very little duplication in the rest of our pattern library.

Critiques from peers - 3

We got JM to review the site and he thought it was very good. He helped us catch the edit/delete button on the paster card hadn't been linked but other than that he had no issues running through the site.

Final grade: 16/18

@thomasjbradley