search

Yarden-zamir / ProjectGear

Project gear modpack development
20 stars 12 forks source link

Whitelist various tile entities for Charset Carry #454

Open TheDeviantCrafter opened 6 years ago

TheDeviantCrafter commented 6 years ago

By default, Charset Carry can't be used to pick up many modded tile entities. We can whitelist those in the config. I'll copy/paste what asie told me in a PM:

There is a whitelist. I do not pre-whitelist things like CarryOn because that leads to bugs with, say, multiblock structures. I can name at least one 1.7.10 mod (BetterStorage) where not blacklisting a certain tile entity would cause severe issues Not sure about 1.12+, but the possibility remains mods.charset.Registry.allow("carry", "minecraft:stone"); mods.charset.Registry.allow("carry", ); mods.charset.Registry.forbid("carry", "minecraft:stone"); mods.charset.Registry.forbid("carry", );

charset/modules/lib.cfg has a whitelist and blacklist config option for the "functionality registry" the format is "carry:minecraft:stone" or "carry:minecraft:*" it's a bit more spartan than CraftTweaker, but then most pack devs use it anyway (Another reason why it's so spartan is that I'm slowly planning my own 'scripting' module for Charset)

You can whitelist entire mods at a time. GENERALLY, if a mod does not contain multiblock structures, it should be fine to do so. Also, Quark adds support on their side, or at least used to. (The same "minecraft:*" syntax will work in CraftTweaker, FWIW)

TheDeviantCrafter commented 6 years ago

Ideally I'd like all tile entites that can be moved safely to be whitelisted. The highest priority ones are storage blocks such as iron chests and storage drawers.