search

Yaribz / SPADS

SpringRTS Perl Autohost for Dedicated Server
GNU General Public License v3.0
17 stars 16 forks source link

Remove the letters i, l, o and 0 from possible automatically generate… #55

Closed Beherith closed 2 years ago

Beherith commented 2 years ago

…d room passwords, as they have lead to multiple counts of confusion

Even though they can only be lowercase, but users dont know/expect that :D

Yaribz commented 2 years ago

Thanks for your PR !

I totally understand the problem, but I'd like to solve it differently so that the requirements from one component don't affect all the components using the generatePassword function.

I will update the generatePassword function so that it will accept an optional parameter specifying the characters allowed in the password.

Unfortunately it means it will require an update of the ClusterManager plugin also to fix the original problem, but I think it is a better long-term solution.

Yaribz commented 2 years ago

You just need to replace your ClusterManager.pm file in your plugin directory with this one, and do a !plugin ClusterManager reload on your manager instances and it should be good.