Yaribz / SPADS

SpringRTS Perl Autohost for Dedicated Server
GNU General Public License v3.0
17 stars 16 forks source link

InGameMute plugin should still allow players to vote #60

Closed Jazcash closed 1 year ago

Jazcash commented 1 year ago

Currently, I believe it's this plugin that's preventing muted players from being able to vote, yet they are still included as part of the vote participation pool.

My suggestion would be to trim the optional message arg from any commands that have them and forward the bare command for muted players. e.g.

!stop haha u suck -> !stop

Yaribz commented 1 year ago

Currently, I believe it's this plugin that's preventing muted players from being able to vote, yet they are still included as part of the vote participation pool.

It's not the plugin directly, it's the engine mute system which simply prevents the player's ingame messages from being sent to the autohost, as part of the mute functionality. So nothing can be done at SPADS side regarding this without engine changes... Maybe the plugin should remove muted players from SPADS vote pool, but currently they are still able to vote using lobby messages so I'm not sure...

Jazcash commented 1 year ago

I think this is a limitation of using say to transmit player commands, rather using a dedicated API through which clients can send/receive commands. But I guess you'd have to implement that same interface both in SPADS and in engine and keep it consistent, a bit painful

Will close anyways if it's an engine issue