Yaribz / SPADS

SpringRTS Perl Autohost for Dedicated Server
GNU General Public License v3.0
17 stars 16 forks source link

"failed to upload demo" #7

Closed abma closed 10 years ago

abma commented 10 years ago

most spads autohosts seems to fail to upload demo. i don't have access to a full log file, but very likely its caused by the update to spring 98.0 with this in changelog:

! demofile string in infolog changed "recording demo: %s" -> "Recording demo to: %s"

see also http://springrts.com/phpbb/viewtopic.php?f=64&t=32653

Yaribz commented 10 years ago

No, SPADS only parses the infolog file as a fallback mechanism for old Spring engines. The demofile string is correct for old Spring engines so code doesn't need to be updated here. Bug reports without log messages are quite useless, for example here the problem might just be due to a misconfiguration at SPADS side. If no additional info is provided I will close this issue.

nixtux commented 10 years ago

Add output from spads running in console, first think ive noticed is if you check link 90 then line 103 location for demo does not match up http://pastebin.com/Ask4UnNV ,if you need any other logs please ask , demo upload did work on this server with 96

Yaribz commented 10 years ago

According to your log, the Spring Autohost interface has been silently modified in Spring 98: the SERVER_STARTPLAYING message no longer contains a relative filename for the demo but an absolute one, which obviously broke backward compatibility for autohosts using this data.

Yaribz commented 10 years ago

I have implemented a workaround in SPADS 0.11.21 (only in unstable for now), can you confirm it fixes the problem?

nixtux commented 10 years ago

Thanks works fine now, http://replays.springrts.com/replay/726d3e54d319348bd43ec3522a464a28/

Yaribz commented 10 years ago

fixed by c3b389a

abma commented 10 years ago

thanks a lot! :-)

FabriceFABS commented 10 years ago

Thank you VM. :+1: