I have fixed the incorrect order of generic parameter names for AddFunction methods, usage is unchanged, it was just incorrect naming.
Please check if the pull request fulfills these requirements
[x] Tests for the changes have been added (for bug fixes / features)
[x] Does it pass all existing unit tests without modification?
If not, what did you change?
If you altered it significantly, what coverage issue did you fix?
[n/a] Docs have been added / updated (for bug fixes / features)
[x] CHANGELOG.md has been updated to describe this change
What kind of change does this pull request introduce?
[x] Bug Fix
[ ] Feature
[ ] Something else
What is the current behavior?
The AddFunction methods all have an inverted parameter list, where the return value is specified first. If you attempt to respect what's listed as TResult it will not match the order used by the Func, and will show an error.
What is the new behavior (if this is a feature change)?
The names of the generic parameter list involved in the AddFunction methods is now correctly ordered to match the Func that is passed in.
// New
void AddFunction<T1... TResult>(string name, Func<T1... TResult> implementation) {
Does this pull request introduce a breaking change?
There should be no change, unless there is codegen based on this code or something else I'm not aware of.
Anything that previously did work must have ignored the names, and anything that didn't couldn't compile anyway.
I have fixed the incorrect order of generic parameter names for
AddFunction
methods, usage is unchanged, it was just incorrect naming.What kind of change does this pull request introduce?
[x] Bug Fix
[ ] Feature
[ ] Something else
What is the current behavior?
The
AddFunction
methods all have an inverted parameter list, where the return value is specified first. If you attempt to respect what's listed asTResult
it will not match the order used by theFunc
, and will show an error.The names of the generic parameter list involved in the
AddFunction
methods is now correctly ordered to match theFunc
that is passed in.There should be no change, unless there is codegen based on this code or something else I'm not aware of.
Anything that previously did work must have ignored the names, and anything that didn't couldn't compile anyway.