search

YarnSpinnerTool / YarnSpinner

Yarn Spinner is a tool for building interactive dialogue in games!
https://yarnspinner.dev
MIT License
2.34k stars 201 forks source link

LineView.DismissLine enables/disables actions without corresponding ContinueActionType #302

Closed fmoo closed 3 years ago

fmoo commented 3 years ago

What is the current behavior?

If continueActionReference was set, but continueActionType has been changed to None, continueActionReference incorrectly continues to have .Disable() called after the line is shown.

Please provide the steps to reproduce, and if possible a minimal demo of the problem:

  1. Use new Unity Input System
  2. Open Window > Analysis > InputDebugger
  3. Change LineView's continueActionType to Input System Action from Asset
  4. Assign continueActionReference
  5. Change LineView's continueActionType back to None
  6. Enter play mode and run through a cutscene (manually calling lineView.OnContinueClicked to advance)
  7. Upon completion of the cutscene, observe the action reference in the Input Debugger now shows (Disabled)

What is the expected behavior?

Input Action reference is not enabled or disabled at all when continueActionType is None.

This likely also occurs with direct InputActions

Please tell us about your environment:

Other information

fmoo commented 3 years ago

Oops, I meant to open this in https://github.com/YarnSpinnerTool/YarnSpinner-Unity/issues