YarnSpinnerTool / YarnSpinner

Yarn Spinner is a tool for building interactive dialogue in games!
https://yarnspinner.dev
MIT License
2.3k stars 201 forks source link

Language Server Completion hangs, breaks after many inline options for the remainder of the file #349

Closed fmoo closed 1 year ago

fmoo commented 1 year ago

What is the current behavior?

When working in vscode on a file with a node with a large number of -> inline options (e.g., more than 13), attempting to invoke the custom command completion anywhere after the branch hangs with "Loading...". The more options, the longer the hang (and recovery time of the LSP).

Please provide the steps to reproduce, and if possible a minimal demo of the problem:

Create a node with 13+ -> options and lines of dialogue below each.

Attempt to invoke custom command completion via typing e.g., <<p and pressing ctrl+space after the 13th line of dialogue (indented) or even try to create a whole new node and use it. The call will either never finish or take forever and return no results after many seconds.

image image image

Inserting a new node between Bug1 and Bug2 and attempting to use code completion in there works just fine; image

What is the expected behavior?

Would expect the typeahead to suggest <<wait>> or <<if>> or <<stop>> etc.

Please tell us about your environment:

Other information

Here's a copy of my assets folder with the bug (title: Bug2): Assets.zip

McJones commented 1 year ago

I definitely know where the LSP lives in the repos...