Mini-Micro-Optimization

YaroslavGaponov / node-jvm

java virtual machine in pure node.js

2.11k stars 176 forks source link

Closed Searle closed 10 years ago

Searle commented 10 years ago

Not important, but just catched my eyes: In libs/opcodes.js, the line

if (this._cache[opcode]) {

should probably read

if (opcode in this._cache) {

Otherwise, the cache is not used for nop's (opcode == 0x00).

YaroslavGaponov commented 10 years ago

yep, thank you