search

Yarroudh / ZRect3D

Command-Line Interface (CLI) application to automatically correct buildings ground-floor elevation in 3D city models.
BSD 3-Clause "New" or "Revised" License
6 stars 3 forks source link

integers-coordinates-of-the-vertices #3

Open collaer opened 1 year ago

collaer commented 1 year ago

Hello Anass,

I figured out that in https://www.cityjson.org/specs/1.1.3/#coordinates-of-the-vertices the vertices should be integers and not float.

I'd like to discuss and eventually submit a MR to change somewhere about here https://github.com/Yarroudh/ZRect3D/blob/main/zrect.py#L125 the floats into integers.

Maybe we should think update updating the transformation matrix if we do not want to round values to integers?

Not having integers is generally just fine (ninja etc are okay) but it could be annoying and throwing some errors when using some cjio functionalities (like vertices cleaning, removing duplicates, etc.)

Julien

Yarroudh commented 1 year ago

Hello @collaer, I think you are right. I did not pay attention to this in CityJSON specs. May be rounding the values of the coordinates can fix that.