Yash-Handa / logo-ls

Modern ls command with vscode like File Icon and Git Integrations. Written in Golang
MIT License
1.13k stars 46 forks source link

When using the '-h' flag, owner disappears #3

Open youssefazrak opened 3 years ago

youssefazrak commented 3 years ago

When using the -h flag, the owner disappears.

Example below with logo-ls -larth:

drwxr-xr-x⠀staff⠀96   ⠀Sep 16 09:57:50⠀ﱮ⠀..
-rw-r--r--⠀staff⠀2.4K ⠀Sep 16 09:57:50⠀⠀output.tf
-rw-r--r--⠀staff⠀2.5K ⠀Sep 16 09:57:50⠀⠀main.tf

Should get the ls -larth equivalent where the owner is not missing:

ls -larth                                          
drwxr-xr-x   3 youssefazrak  staff    96B Sep 16 09:57 ..
-rw-r--r--   1 youssefazrak  staff   2.4K Sep 16 09:57 output.tf
-rw-r--r--   1 youssefazrak  staff   2.5K Sep 16 09:57 main.tf

OS:

sw_vers                                                                  
ProductName:    Mac OS X
ProductVersion: 10.15.6
BuildVersion:   19G2021

Version 1.3.5 is being used.

Go version: go version go1.14.3 darwin/amd64

youssefazrak commented 3 years ago

I can have a look and see if a PR can be done. If you have pointers I will gladly take them.

nikoksr commented 3 years ago

@youssefazrak for me logo-ls -larth is printing my name but in contrast to the regular ls -larth it doesn't print my username but my full name. I would definitely prefer the actual username and not my full name since my username is used when handling filesystem access permissions.


logo-ls -larth:

drwxr-xr-x ⠀Niko Köser ⠀niko⠀4.0K ⠀Sep 23 16:07:44⠀ﱮ⠀..
drwxr-xr-x⠀ Niko Köser ⠀niko⠀4.0K ⠀Sep 23 16:07:47⠀⠀.github/
drwxr-xr-x  Niko Köser ⠀niko⠀4.0K ⠀Sep 23 16:07:47⠀⠀.vscode/

ls -larth:

drwxr-xr-x niko niko    4 KB Wed Sep 23 16:07:44 2020   ..
drwxr-xr-x niko niko    4 KB Wed Sep 23 16:07:47 2020   .github
drwxr-xr-x niko niko    4 KB Wed Sep 23 16:07:47 2020   .vscode

Build and tested logo-ls version 1.3.5 from source under Arch Linux (Kernel 5.8.10) with Go version 1.15.2.

youssefazrak commented 3 years ago

@nikoksr in this case, you should probably open a different issue.