Yash-Handa / logo-ls

Modern ls command with vscode like File Icon and Git Integrations. Written in Golang
MIT License
1.13k stars 46 forks source link

minor mod: Using empty (U+0020) instead of brailEmpty #35

Open canta2899 opened 2 years ago

canta2899 commented 2 years ago

I've been using logo-ls for a while and in some cases white-spaces between icons and file names were rendered as follows.

brailEmpty

I checked out the implementation and noticed that the U+2800 Braille pattern has been used since commit 1a227b5 as a space character, except for when the -i flag is risen. However, I found out that U+2800 does not act as a proper space in the Unicode standard, according to this unicode-explorer page.

I replaced U+2800 with U+0020, the standard space character. Then, the output was properly rendered on every terminal.

empty

I hope this PR might be helpful and thank you for making logo-ls!