Yash-Handa / logo-ls

Modern ls command with vscode like File Icon and Git Integrations. Written in Golang
MIT License
1.14k stars 43 forks source link

Use of Outdated Glyphs #45

Open manuth opened 1 year ago

manuth commented 1 year ago

logo-ls currently uses outdated nf-mdi-* glyphs which have, according to the nerdfont website, been removed.

These need to be migrated to be used with up-to-date nerd fonts

D3vil0p3r commented 1 year ago

I'm getting this behavior but I'm not sure if it is related to the issue above: image

PS: is still this repository maintained?

pi9x commented 1 year ago

Not sure if this is the reason but I'm getting this even though I have changed many nerd fonts. This issue happens to logo-ls only. The icons display properly when I use lsd.

image

D3vil0p3r commented 1 year ago

Not sure if this is the reason but I'm getting this even though I have changed many nerd fonts. This issue happens to logo-ls only. The icons display properly when I use lsd.

image

It occurs because you installed google-fonts and it can produce that wrong glyphs.

pi9x commented 1 year ago

Not sure if this is the reason but I'm getting this even though I have changed many nerd fonts. This issue happens to logo-ls only. The icons display properly when I use lsd. image

It occurs because you installed google-fonts and it can produce that wrong glyphs.

No I use nerd fonts from https://www.nerdfonts.com/

orhnk commented 1 year ago

Have a look at here

manuth commented 1 year ago

Downgrading Nerd Fonts is not a fix, tho 😅 As a fix, I'd rather recommend you to locally merge this Pull Request and build your own logo-ls

manuth commented 1 year ago
orhnk commented 1 year ago

image

:/

manuth commented 1 year ago

Ouch - now that's strange. Did you merge PR #46? Also - what version is your Nerd Font?

orhnk commented 1 year ago

Did you merge PR https://github.com/Yash-Handa/logo-ls/pull/46?

I cloned your fork and compiled it as following:

go mod tidy
go build

Also - what version is your Nerd Font?

I just reinstalled JetBrains Nerd Font from the official site

manuth commented 1 year ago

It does work for me - even with the JetBrains Nerd Font enabled. Be sure to check out the branch nerd-font-3 of my repository.

orhnk commented 1 year ago

Somehow I did clone the original repo?!? Nvm thanks for the fast response and sorry.

Here:

image

manuth commented 1 year ago

no worries, you're fine 😄 I'm glad I could help!