correcting SQL requests on leaderboard and history pages

YashasG98 / Multiplayer-Game-Server

A multiplayer game matchmaking server for Snake and Ladders and Connect Four

48 stars 27 forks source link

correcting SQL requests on leaderboard and history pages #28

Closed DelaMarc closed 4 years ago

DelaMarc commented 4 years ago

Hello, I noticed a bug when I tried to access the Leaderboard ang game history pages. Exceptions were raised, indicating there were errors in the sql requests of those pages. After investigating, I noticed the typing "select @rank:=@rank+1 as rank" was incorrect and I had to change it to "select @rank:=@rank+1 as _rank" to make it work. I don't know if this happens with other versions of SQL server than mine so I subit this modification.

Shashwatha-Mitra commented 4 years ago

Hey! The original query worked fine on the SQL server we had running. Not too sure why it didn't work for you.

DelaMarc commented 4 years ago

I see... well I wasn't sure either if this needed to be committed or not. I guess I can't hurt to do it this way, thanks for merging it.