search

Yaskawa-Global / motoros2

ROS 2 (rcl, rclc & micro-ROS) node for MotoPlus-compatible Yaskawa Motoman robot controllers
96 stars 20 forks source link

Change `double` comparison to use epsilon instead of 0.0 #236

Closed ted-miller closed 5 months ago

ted-miller commented 5 months ago

Regarding https://github.com/Yaskawa-Global/motoros2/issues/233#issuecomment-2045896777

I don't know if this will have an impact on #233. But it does seem like a potential problem.

gavanderhoorn commented 5 months ago

@ted-miller: I suggest we close this in favour of the more correct fix @yai-rosejo is preparing (https://github.com/Yaskawa-Global/motoros2/issues/233#issuecomment-2052605104)

ted-miller commented 5 months ago

agreed