search

Yaskawa-Global / motoros2

ROS 2 (rcl, rclc & micro-ROS) node for MotoPlus-compatible Yaskawa Motoman robot controllers
96 stars 20 forks source link

msbuild ci: match full paths in `mpBuilder` output #247

Closed gavanderhoorn closed 5 months ago

gavanderhoorn commented 5 months ago

By itself this won't magically work, but with an updated mpBuilder this will allow Github to annotate the correct file at the correct line nr with the error or warning output by mpBuilder, facilitating PR reviews.

Example:

image

note the annotation is still not entirely complete as the full path is missing, but that's something we need to clear up on the mpBuilder side I believe.

ted-miller commented 5 months ago

Which mpBuilder update are you referring to? I'm confused because there's an email eight minute before this that says it's not necessary.

gavanderhoorn commented 5 months ago

E-mail was a bit unclear. No updates on the mpBuilder side are needed for this to work. The Github problem matcher does need to be updated, which is what this PR does.