search

Yaskawa-Global / motoros2

ROS 2 (rcl, rclc & micro-ROS) node for MotoPlus-compatible Yaskawa Motoman robot controllers
101 stars 21 forks source link

Config file in releases zip file outputs errors when processed through linter #259

Closed jimmy-mcelwain closed 5 months ago

jimmy-mcelwain commented 5 months ago

I was going through the setup instructions for motoros2 on my machine. I downloaded and unzipped the file motoros2_0.1.2_yrc1000_humble.zip from the releases page. When I ran the linter as suggested in the setup instructions, I got the following output. 

(venv_yamllint) jimmy@jimmy-ThinkPad-T580:~/Desktop/motoros2/config$ yamllint -s . && echo "all ok"
./motoros2_config.yaml
  1:4       error    wrong new line character: expected \n  (new-lines)
  8:2       warning  missing starting space in comment  (comments)
  14:2      warning  missing starting space in comment  (comments)
  15:2      warning  missing starting space in comment  (comments)
  21:2      warning  missing starting space in comment  (comments)
  28:2      warning  missing starting space in comment  (comments)
  30:2      warning  missing starting space in comment  (comments)
  34:2      warning  missing starting space in comment  (comments)
  36:2      warning  missing starting space in comment  (comments)
  40:2      warning  missing starting space in comment  (comments)
  42:2      warning  missing starting space in comment  (comments)
  63:2      warning  missing starting space in comment  (comments)
  65:2      warning  missing starting space in comment  (comments)
  73:2      warning  missing starting space in comment  (comments)
  88:2      warning  missing starting space in comment  (comments)
  90:2      warning  missing starting space in comment  (comments)
  124:2     warning  missing starting space in comment  (comments)
  126:2     warning  missing starting space in comment  (comments)
  133:2     warning  missing starting space in comment  (comments)
  140:2     warning  missing starting space in comment  (comments)
  151:2     warning  missing starting space in comment  (comments)
  163:2     warning  missing starting space in comment  (comments)
  165:2     warning  missing starting space in comment  (comments)
  173:81    error    line too long (81 > 80 characters)  (line-length)
  181:2     warning  missing starting space in comment  (comments)
  182:2     warning  missing starting space in comment  (comments)
  182:81    error    line too long (105 > 80 characters)  (line-length)
  184:2     warning  missing starting space in comment  (comments)
  197:2     warning  missing starting space in comment  (comments)
  203:81    error    line too long (88 > 80 characters)  (line-length)
  205:81    error    line too long (84 > 80 characters)  (line-length)
  225:2     warning  missing starting space in comment  (comments)
  230:81    error    line too long (81 > 80 characters)  (line-length)
  242:2     warning  missing starting space in comment  (comments)
  254:2     warning  missing starting space in comment  (comments)
  256:2     warning  missing starting space in comment  (comments)
  270:2     warning  missing starting space in comment  (comments)

This is without any modifications to the yaml file. I think that either the file should be modified or more likely the .yamllint file should be added to the zip.

gavanderhoorn commented 5 months ago

Those .zips don't appear to contain the yamllint config file.

That's most likely why yamllint isn't happy.

The previous release did ship with that file included. Perhaps @ted-miller forgot to add it to the .zip?

ted-miller commented 5 months ago

The release zips have been updated.