search

Yaskawa-Global / motoros2

ROS 2 (rcl, rclc & micro-ROS) node for MotoPlus-compatible Yaskawa Motoman robot controllers
96 stars 20 forks source link

main: incorrect usage of `UINT_MAX` in period calculation #301

Closed gavanderhoorn closed 4 weeks ago

gavanderhoorn commented 4 weeks ago

I'm not entirely sure, but shouldn't this:

https://github.com/Yaskawa-Global/motoros2/blob/d249d850d64c295fb5f7feeaa61787a84d3b25ad/src/main.c#L159

actually use ULONG_MAX instead of UINT_MAX?

tickDiff is a:

https://github.com/Yaskawa-Global/motoros2/blob/d249d850d64c295fb5f7feeaa61787a84d3b25ad/src/main.c#L155

Minor, but still.