Yaskawa-Global / motoros2

ROS 2 (rcl, rclc & micro-ROS) node for MotoPlus-compatible Yaskawa Motoman robot controllers
96 stars 20 forks source link

Make status IO signals configurable #34

Open gavanderhoorn opened 1 year ago

gavanderhoorn commented 1 year ago

MotoROS2 currently has a hard-coded set of IOs it uses for signalling internal application status:

https://github.com/Yaskawa-Global/motoros2/blob/08329e5a1646315bffb5effdb40857eaea343523/src/ControllerStatusIO.h#L11-L27

These indices should be made configurable, to allow users with conflicting IO assignments to use MotoROS2 without having to rebuild the application.

gavanderhoorn commented 1 year ago

While not necessarily required (as these signals are standard and reserved by Yaskawa for these purposes), it might be interesting to also allow configuration of the following signals:

https://github.com/Yaskawa-Global/motoros2/blob/08329e5a1646315bffb5effdb40857eaea343523/src/ControllerStatusIO.c#L268-L298

The same approach used for the IO_FEEDBACK_* signals could potentially be used.

ted-miller commented 1 year ago

While not necessarily required (as these signals are standard and reserved by Yaskawa for these purposes), it might be interesting to also allow configuration of the following [IO_ROBOTSTATUS_] signals

I disagree with this point. Those signals are hardcoded in each robot controller. Given that they are vital and safety-related indicators, they should not be allowed to be easily change.


Working on this issue would also be a good opportunity to replace the tabs w/ spaces.

image

gavanderhoorn commented 1 year ago

Looks like @SejalBehere ended up doing some work in this direction.

See https://github.com/Yaskawa-Global/motoros2/compare/main...SejalBehere:motoros2:Configurable-IO-Signals.