search

YasuakiHonda / Maxima-on-Android-AS

Maxima on Android imported to Android Studio
23 stars 13 forks source link

Script file loading #3

Closed ghost closed 7 years ago

ghost commented 7 years ago

My idea was to allow the user to load commands from a Maxima script file. This may be a bit hacked together, please excuse that.

Some things to note:

YasuakiHonda commented 7 years ago

Dear Kadabash san, Thanks for the contribution. Currently I am in the process of preparing for the release of MoA 3.0 in a week. After MoA 3.0, I will review your contribution for merge. Sorry that I cannot work on your contribution immediately.

ghost commented 7 years ago

I have found some major flaws in my implementation. I will rework it and resubmit it when it works reliably.

YasuakiHonda commented 7 years ago

Thanks for let me know this. I hope you will be back with fixes. Note that I have pushed some changes made for MoA 3.0 in the main branch recently.

ghost commented 7 years ago

Ok, I have had some time to test this now. It seems to work quite well.

ghost commented 7 years ago

I will attach a test script file which works for me. plot3dsurface.mac.zip Just unzip it and select "Select script file" in the menu.

YasuakiHonda commented 7 years ago

Dear Kadabash san, I have successfully compile and run this new functionality in my local environment. It worked great with the files downloaded by browser. For files I put using ADB, it failed to choose. I am still experimenting this new feature. But this is definitely useful and I will merge it in the future.

Please take a look and respond to the comments I have made to your code.

Thanks!!

YasuakiHonda commented 7 years ago

Dear Kadabash san,

Thanks for all the work that make this contribution. As this feature is merged, this will appear in the MoA 3.1 release, which is to appear in some time in this summer.

The documents stored in Dropbox or Google Drive needs to be downloaded first, then this feature is used to load the file into Maxima. If you continue to work on the development of this feature so that Dropbox / Google Drive folders can also appear in the navigation UI, it would be really terrific. I don't know how difficult it is, though...

Anyway, thanks for your contribution!!

ghost commented 7 years ago

Dear Mr Honda,

I am glad you liked my idea! Thanks also for your constructive feedback and patience.
On the issue of cloud storage: Dropbox, Google Drive, and the like should appear in the File Picker from the Storage Access Framework. Below are a series of screenshots that show how a Nextcloud cloud server is already integrated with the dialogue that appears when you select "Select script file". Loading from this directly works fine, and in theory, this should also work for Dropbox, etc. (Can't test that, though, as I don't use these)
screenshot_cloud_storage
The integration into the Storage Access Framework should be handled by the respective app (Google Drive, Dropbox, ...).

YasuakiHonda commented 7 years ago

Dear Kadabash san, Oh, yes!! I didn't notice since I was on emulator. However, as soon as I read your above message, I tried this on my phone, and yes, the Google Drive appeared!! I successfully load some sample mac file from there!!

Once again, thanks for this great contribution. This is terrific!