search

Yatekii / imgui-wgpu-rs

Dear imgui renderer for wgpu-rs.
MIT License
256 stars 84 forks source link

Support winit 0.25 #64

Closed andraantariksa closed 3 years ago

andraantariksa commented 3 years ago

The title say everything

cwfitzgerald commented 3 years ago

There does not seem to be a winit release greater than 0.25, is there something you are needing support for in particular?

ChristianIvicevic commented 3 years ago

Now there is and while attempting to attach my window instance to the platform I am receiving a version/type mismatch:

Screenshot 2021-09-02 at 02 11 23

andraantariksa commented 3 years ago

There does not seem to be a winit release greater than 0.25, is there something you are needing support for in particular?

I mean winit 0.25. Maybe I should change the title.

I need some of the features in winit 0.25.

cwfitzgerald commented 3 years ago

Oh I see. I didn't realize we didn't support 0.25 formally. It should be as easy as bumping the cargo.toml. We don't use that many winit features. You're using the simple api?

andraantariksa commented 3 years ago

Simple api?

cwfitzgerald commented 3 years ago

See https://github.com/Yatekii/imgui-wgpu-rs/blob/master/examples/basic_simple_api.rs

If you aren't using the simple api, winit isn't even a dependency of ours.

andraantariksa commented 3 years ago

Nope, I need access to winit

cwfitzgerald commented 3 years ago

My point is that if you aren't using the simple api, we don't have a winit dependency at all. What api are you calling that is getting this mismatch? Oh you're getting on the winit platform, that's not our code, the platform is from https://github.com/imgui-rs/imgui-rs/tree/master/imgui-winit-support.

andraantariksa commented 3 years ago

I see, my bad. Just need to change the default features.

imgui-winit-support = { version = "0.7.0", default-features = false, features = ["winit-25"] }

Closing this issue.