Fix issue 4 by parsing into u128 - Githubissues

Yatekii / qrbill

2 stars 3 forks source link

Fix issue 4 by parsing into u128 #5

Closed jacg closed 3 weeks ago

jacg commented 3 weeks ago

Trivial fix for #4: parse into u128 instead of u64.

However, the earlier commits introduce stuff which is not strictly necessary, including

Add dev-dependency on rstest
Add a bunch of tests
Change try_new parameter from String to &str
Rename Error::InvalidFormat to Error::MissingLeadingRF
In Error::InvalidCharacter, report all invalid characters present

Alternatively, I could donate my implementation of ISO 11649, as discussed in #4.

jacg commented 3 weeks ago

I have rebased this, so that it contains nothing besides the trivial fix.